[skip circleci] Update release instructions #2384
Conversation
|
The build check has been succesfull in my repo: https://github.com/jneira/haskell-language-server/actions/runs/1489172293 |
docs/contributing/releases.md
Outdated
| - [ ] bump up versions of changed packages. All are optional but [haskell-language-server itself](https://github.com/haskell/haskell-language-server/blob/master/haskell-language-server.cabal). | ||
| - [ ] create the tag and make an initial prerelease to trigger the ci workflow (see details below) | ||
| - [ ] contact ghcup team (#haskell-ghcup irc channel or via its [repo](https://gitlab.haskell.org/haskell/ghcup-hs/-/issues)) to try to sync our release and its inclusion in ghcup | ||
| - [ ] check uploaded binaries (see windows note below) and the release description (usually the changelog entry) and uncheck the prerelease box |
There was a problem hiding this comment.
which uploaded binaries? where are they? I guess they were generated somewhere based on the previous workflows?
| * [ ] create ${version}-hackage branch to trigger the hackage github workflow which will upload all changed packages to hackage as candidates | ||
| * [ ] check manually candidates in hackage | ||
| * [ ] publish them definitely | ||
| - [ ] bump up package versions following the [pvp specification](https://pvp.haskell.org/) if they are not already updated. You could use [policeman](https://github.com/kowainik/policeman) to help with this step. |
There was a problem hiding this comment.
how is this different to the previous verison-bumping step on line 29? should there just be one version-bumping step done before any releasing?
There was a problem hiding this comment.
The difference is in the All are optional but haskell-language-server itself part. For hackage bump up versions following pvp is mandatory. For the github release you only need to bump up hls itself.
At the beginning we did not have the github and hackage release in sync and we only bumped up plugin and package versions in a systematic way for the hackage one. In last releases i bumped up versions before start the release engine.
Co-authored-by: Michael Peyton Jones <[email protected]>
I see some repetition between the check list and the descriptions below but maybe it is necessary. Anyways it could be rewritten in an ongoing pr. |
jneira
changed the title
Uh oh!
There was an error while loading. Please reload this page.